-
Notifications
You must be signed in to change notification settings - Fork 27
Add support for Kubernetes Audit #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert here but so far looks good to me. The only detail worth mentioning is when updating the cluster, the abscence of an audit config in the payload enabled: false
That is expected behavior of an optional attribute in terraform. Adding a note never hurts. |
fcfd401 to
cd67171
Compare
Co-Authored-By: Loic Blot <[email protected]>
cd67171 to
5b2da4c
Compare
|
there is some acceptance tests to fix, some are out of this PR scope, anyway |
3bb5b8d to
68cd7ab
Compare
27b1fca to
19c46c3
Compare
19c46c3 to
5448388
Compare
Description
Add support for Kubernetes Audit - Create / Update / Read
Taken by @nerzhul
Checklist
(For exoscale contributors)
Testing